projects
/
xen.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a0c1a38
)
tmem: typo causes incorrect return on out-of-memory
author
Keir Fraser
<keir.fraser@citrix.com>
Tue, 9 Mar 2010 17:53:01 +0000
(17:53 +0000)
committer
Keir Fraser
<keir.fraser@citrix.com>
Tue, 9 Mar 2010 17:53:01 +0000
(17:53 +0000)
This classic typo in tmem would result in a false positive
report on a tmem "put" operation if a (unfragmented) page
of memory is completely unavailable.
Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
xen/common/tmem.c
patch
|
blob
|
history
diff --git
a/xen/common/tmem.c
b/xen/common/tmem.c
index c2f6c74f1fda847e01b53633155bf78dfbc536b9..42f4569dbc6cbf5dcb59feea3e0b847b963446c3 100644
(file)
--- a/
xen/common/tmem.c
+++ b/
xen/common/tmem.c
@@
-1308,7
+1308,7
@@
static NOINLINE int do_tmem_put(pool_t *pool,
copy_uncompressed:
if ( ( pgp->pfp = tmem_page_alloc(pool) ) == NULL )
{
- ret =
=
-ENOMEM;
+ ret = -ENOMEM;
goto delete_and_free;
}
/* tmh_copy_from_client properly handles len==0 (TMEM_NEW_PAGE) */